Re: [MM][PATCH] mm-glib: use correct enum type



On 27/04/13 07:21, Yunlian Jiang wrote:
This patch fixes mismatched enum type for a function parameter, which
fixes the following clang warning:

Patch doesn't seem to be cleanly applicable with "git am". How did you
create it? Please use either git send-email or git format-patch.


mm-manager.c:112:65: error: implicit conversion from enumeration type

'GDBusObjectManagerClientFlags' to different enumeration type 'GDBusProxyFlags'
      [-Werror,-Wenum-conversion]
                                                                flags,
                                                                ^~~~~
1 error generated.

Bug reported on https://code.google.com/p/chromium/issues/detail?id=235989


diff --git a/libmm-glib/mm-manager.c b/libmm-glib/mm-manager.c
index 46dd8ce..efea9b0 100644
--- a/libmm-glib/mm-manager.c
+++ b/libmm-glib/mm-manager.c
@@ -93,7 +93,7 @@ ensure_modem_manager1_proxy (MMManager  *self,
 {
     gchar *name = NULL;
     gchar *object_path = NULL;
-    GDBusObjectManagerClientFlags flags = G_DBUS_OBJECT_MANAGER_CLIENT_FLAGS_NONE;
+    GDBusProxyFlags flags = G_DBUS_PROXY_FLAGS_NONE;
     GDBusConnection *connection = NULL;
 
     if (self->priv->manager_iface_proxy)

--

1.8.2.1



_______________________________________________
networkmanager-list mailing list
networkmanager-list gnome org
https://mail.gnome.org/mailman/listinfo/networkmanager-list



-- 
Aleksander


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]