[MM master] Re: [MM06] [PATCH] sierra: use +CFUN=4 for powering down

[Marius Kotsbak <marius kotsbak gmail com>]

Den 09. sep. 2012 17:39, skrev Marius Kotsbak:
> See patch attached.
>
> sierra: use +CFUN=4 for powering down
>
>  plugins/mm-modem-sierra-gsm.c |   32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

This also needs to be intregrated in the master branch version. Attached 
is my attempt to do it, but it seems not to work. I see no effect of 
disabling the modem with "mmcli -m X -d".

Also, it seems like the power down is not done before the modem enters 
disabled state at startup of MM or after modem is inserted, so I filed a 
bug about that:

https://bugzilla.gnome.org/show_bug.cgi?id=683681

--
Marius

>From ac69eb9a08f821efb674f54292ee90707ca81e29 Mon Sep 17 00:00:00 2001
From: "Marius B. Kotsbak" <marius kotsbak com>
Date: Sun, 9 Sep 2012 18:06:30 +0200
Subject: [PATCH] sierra: use +CFUN=4 for powering down

---
 plugins/sierra/mm-broadband-modem-sierra.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/plugins/sierra/mm-broadband-modem-sierra.c b/plugins/sierra/mm-broadband-modem-sierra.c
index 49c2e22..c8e8f3e 100644
--- a/plugins/sierra/mm-broadband-modem-sierra.c
+++ b/plugins/sierra/mm-broadband-modem-sierra.c
@@ -527,11 +527,14 @@ modem_power_down (MMIfaceModem *self,
         return;
     }
 
-    /* For 3GPP modems we should call parent's power down, but there is no
-     * such power down command in MMBroadbandModem, so just finish here. */
-    g_simple_async_result_set_op_res_gboolean (result, TRUE);
-    g_simple_async_result_complete_in_idle (result);
     g_object_unref (result);
+
+    mm_base_modem_at_command (MM_BASE_MODEM (self),
+                              "+CFUN=4",
+                              3,
+                              FALSE,
+                              callback,
+                              user_data);
 }
 
 /*****************************************************************************/
-- 
1.7.10.4