[PATCH] Fix for Blueman modem being ignored

Currently when a modem device registered by Blueman is connected, NetworkManager reports that there is no associated bluetooth device.

The if statement responsible for this ought to be reporting an error and returning if the driver is named, but not named "bluetooth".

Unfortunately, the true result of strcmp(), zero, has been flipped, meaning only the device name "bluetooth" isn't acceptable as a bluetooth device.

The solution to this was found by Andrew Guskoff, he describes it here;


I picked it up from the Ubuntu/ Arch Linux bug report;


This fixes the problem for me with NetworkManager 0.9.4 (Ubuntu 12.04) and a Nokia N900 phone, Andrew (obviously) and another user who reported trying it on the log.

I've attached a patch I created against a checkout from the NetworkManager git repository.



diff --git a/src/nm-manager.c b/src/nm-manager.c
index c8ce115..88f4257 100644
--- a/src/nm-manager.c
+++ b/src/nm-manager.c
@@ -409,7 +409,7 @@ modem_added (NMModemManager *modem_manager,
 	 * it.  The rfcomm port (and thus the modem) gets created automatically
 	 * by the Bluetooth code during the connection process.
-	if (driver && !strcmp (driver, "bluetooth")) {
+	if (driver && strcmp (driver, "bluetooth")) {
 		nm_log_info (LOGD_MB, "ignoring modem '%s' (no associated Bluetooth device)", ip_iface);

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]