Re: [PATCH] icera: improve parsing of access technologies in %NWSTATE response

[Ben Chan <benchan chromium org>]

On Tue, Oct 16, 2012 at 12:49 AM, Aleksander Morgado
<aleksander lanedo com> wrote:
>
> I pushed this patch as is, but then I realized that the report of
> current access technologies is supposed to give which is the *current*
> access technology being active. We allow reporting more than one for the
> cases where several access technologies are given simultaneously (e.g.
> cdma1x + evdo + lte). So not sure if there is much benefit in giving
> e.g. 4 different technologies like "umts, hsdpa, hsupa, hspa" when the
> modem reports "3G-HSDPA-HSUPA". In this example, umts shouldn't really
> be given I guess, and also we know that HSPA is just HSDPA+HSUPA, so
> giving HSPA only was enough... so... should I revert the patch? :-/
>

I guess that makes sense :)  The previous patch tries to address your
comment in crosbug.com/33483. Let's revert it. The real issue in
crosbug.com/33483 is that nwstate_to_act doesn't handle HSPA+, so I
think we can fix it as follows:

Thanks,
Ben

>From f90c8bea9dae89aceb6d7d0cf037cbc4bc73d2df Mon Sep 17 00:00:00 2001
From: Ben Chan <benchan chromium org>
Date: Tue, 16 Oct 2012 00:55:40 -0700
Subject: [PATCH] icera: parse HSPA+ access technology in %NWSTATE response

---
 plugins/icera/mm-broadband-modem-icera.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/plugins/icera/mm-broadband-modem-icera.c
b/plugins/icera/mm-broadband-modem-icera.c
index db70252..697e8cc 100644
--- a/plugins/icera/mm-broadband-modem-icera.c
+++ b/plugins/icera/mm-broadband-modem-icera.c
@@ -341,6 +341,8 @@ nwstate_to_act (const gchar *str)
         return MM_MODEM_ACCESS_TECHNOLOGY_HSUPA;
     else if (!strcmp (str, "3G-HSDPA-HSUPA") || !strcmp (str, "HSDPA-HSUPA"))
         return MM_MODEM_ACCESS_TECHNOLOGY_HSPA;
+    else if (!strcmp (str, "3G-HSDPA-HSUPA-HSPA+") || !strcmp (str,
"HSDPA-HSUPA-HSPA+"))
+        return MM_MODEM_ACCESS_TECHNOLOGY_HSPA_PLUS;

     return MM_MODEM_ACCESS_TECHNOLOGY_UNKNOWN;
 }
-- 
1.7.7.3