Re: [PATCH] fix build: disable -Werror by default (Bug #679130)

On Fri, Nov 2, 2012 at 3:43 PM, Clemens Buchacher <drizzd aon at> wrote:
> On Fri, Nov 02, 2012 at 10:32:25AM -0400, Pavel Simerda wrote:
>> > On Fri, Nov 02, 2012 at 09:16:29AM -0400, Colin Walters wrote:
>> > > On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote:
>> > >
>> > > > So this has been an issue for a while, and the -Werror flag does
>> > > > not
>> > > > help anything besides breaking the build.
>> > >
>> > > You're going to have to learn how to pass options to "configure" if
>> > > you're building software in general.  It's really the maintainer's
>> > > discretion what the defaults are.
>> >
>> > It is not the purpose of configure to work around
>> > platform-independent
>> > build failures.
>> And?
> And it is therefore not a solution to do nothing and force the package
> maintainers to deal with this issue.

This wasn't handled very nicely, there is that, but there is an actual
point in making warnings errors and forcing anybody compiling to
willingly change configure settings to avoid the build failure: we
don't forget that there is work that needs to be done.

I actually did the porting in Ubuntu. The patch probably doesn't apply
quite as cleanly on git master; but see the attached file which
migrates the calls to gtk_table_* to gtk_grid_*.


Mathieu Trudel-Lapierre <mathieu tl gmail com>
Freenode: cyphermox, Jabber: mathieu tl gmail com
4096R/EE018C93 1967 8F7D 03A1 8F38 732E  FF82 C126 33E1 EE01 8C93

Attachment: gtk_table_to_gtk_grid.patch
Description: Binary data

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]