Re: [MM PATCH] novatel-lte: increase the wait after SIM unlock to 3 seconds

[Aleksander Morgado <aleksander lanedo com>]

On 01/11/12 05:31, Ben Chan wrote:
> After repeated stress tests on a few Novatel E362 modems and SIM cards,
> it is revealed that a 3-second wait after SIM unlock is necessary for
> reliably reading ICCID and IMSI through the SIM interface.

Pushed, thanks.

BTW, Novatel LTE modems can now be handled by QMI as well, but I guess
we can keep the AT-based novatel-lte plugin around as long as we allow
`--without-qmi' in configure.


> ---
>  plugins/novatel/mm-broadband-modem-novatel-lte.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/plugins/novatel/mm-broadband-modem-novatel-lte.c b/plugins/novatel/mm-broadband-modem-novatel-lte.c
> index da855fc..6f2e7e2 100644
> --- a/plugins/novatel/mm-broadband-modem-novatel-lte.c
> +++ b/plugins/novatel/mm-broadband-modem-novatel-lte.c
> @@ -152,9 +152,9 @@ modem_after_sim_unlock (MMIfaceModem *self,
>                                          user_data,
>                                          modem_after_sim_unlock);
>  
> -    /* A 2-second wait is necessary for SIM to become ready.
> +    /* A 3-second wait is necessary for SIM to become ready.
>       * Otherwise, a subsequent AT+CRSM command will likely fail. */
> -    g_timeout_add_seconds (2, (GSourceFunc)after_sim_unlock_wait_cb, result);
> +    g_timeout_add_seconds (3, (GSourceFunc)after_sim_unlock_wait_cb, result);
>  }
>  
>  /*****************************************************************************/
> 


-- 
Aleksander