Re: [PATCH] gsm: define the PPP auth preferences for STATIC and DHCP device use

[Dan Williams <dcbw redhat com>]

On Fri, 2012-03-16 at 09:35 +0000, Andrew Bird wrote:
> When using the either DHCP or STATIC IpMethods the modem manager
> or device itself negotiates / establishes the PPP session so NM
> passes the authentication preferences through.

Pushed to 0.5 and 0.6, thanks.

Dan

> Signed-off-by: Andrew Bird <ajb spheresystems co uk>
> ---
>  .../org.freedesktop.ModemManager.Modem.Gsm.xml     |   30 ++++++++++++++++++++
>  .../org.freedesktop.ModemManager.Modem.Simple.xml  |    1 +
>  2 files changed, 31 insertions(+), 0 deletions(-)
> 
> diff --git a/introspection/org.freedesktop.ModemManager.Modem.Gsm.xml b/introspection/org.freedesktop.ModemManager.Modem.Gsm.xml
> index 354ce4a..ee5076a 100644
> --- a/introspection/org.freedesktop.ModemManager.Modem.Gsm.xml
> +++ b/introspection/org.freedesktop.ModemManager.Modem.Gsm.xml
> @@ -105,6 +105,36 @@
>        </tp:flag>
>      </tp:flags>
>  
> +    <tp:enum name="MM_MODEM_GSM_ALLOWED_AUTH" type="u">
> +      <tp:docstring>
> +        A bitfield describing the network's authentication preference; this is
> +        only for use if the device offers IpMethods of STATIC or DHCP as in
> +        these cases the PPP session is established by the device itself. The
> +        ordering of the bitfield matches Ericsson devices in the range 0..4
> +      </tp:docstring>
> +      <tp:flag suffix="UNKNOWN" value="0x0">
> +        <tp:docstring>Unknown or invalid authentication</tp:docstring>
> +      </tp:flag>
> +      <tp:enumvalue suffix="NONE" value="0x1">
> +        <tp:docstring>Supports no authentication</tp:docstring>
> +      </tp:enumvalue>
> +      <tp:enumvalue suffix="PAP" value="0x2">
> +        <tp:docstring>Supports PAP authentication</tp:docstring>
> +      </tp:enumvalue>
> +      <tp:enumvalue suffix="CHAP" value="0x4">
> +        <tp:docstring>Supports CHAP authentication</tp:docstring>
> +      </tp:enumvalue>
> +      <tp:enumvalue suffix="MSCHAP" value="0x8">
> +        <tp:docstring>Supports MSCHAP authentication</tp:docstring>
> +      </tp:enumvalue>
> +      <tp:enumvalue suffix="MSCHAPV2" value="0x10">
> +        <tp:docstring>Supports MSCHAPv2 authentication</tp:docstring>
> +      </tp:enumvalue>
> +      <tp:enumvalue suffix="EAP" value="0x20">
> +        <tp:docstring>Supports EAP authentication</tp:docstring>
> +      </tp:enumvalue>
> +    </tp:enum>
> +
>      <tp:enum name="MM_MODEM_GSM_ALLOWED_MODE" type="u">
>        <tp:docstring>
>          Describes the device's current access mode preference; ie the specific
> diff --git a/introspection/org.freedesktop.ModemManager.Modem.Simple.xml b/introspection/org.freedesktop.ModemManager.Modem.Simple.xml
> index 6c17c0d..eeb6299 100644
> --- a/introspection/org.freedesktop.ModemManager.Modem.Simple.xml
> +++ b/introspection/org.freedesktop.ModemManager.Modem.Simple.xml
> @@ -22,6 +22,7 @@
>            'apn'          : string (GSM/HSPA only)
>            'number'       : string
>            'rm-protocol'  : uint (CDMA/EVDO only) (1 - Relay, 2 - Network PPP)
> +          'allowed_auth' : uint (GSM/HSPA only) (MM_MODEM_GSM_ALLOWED_AUTH bitfield)
>          </tp:docstring>
>        </arg>
>      </method>