Re: [PATCH] bonding: Convert individual bonding options to a dict



On Wed, 2012-02-15 at 21:50 -0600, Dan Williams wrote:
> On Tue, 2012-02-14 at 14:05 +0100, Thomas Graf wrote:
> > Removes all bonding options properties and adds a "options" dict to hold
> > them all. Accessible via accessor functions. ifcfg interface is
> > unchanged.
> 
> Applied with a few changes; instead of _by_key() use _by_name() since
> that's more appropriate, despite what I chose for the s390 options 3
> years ago :)  Second add #defines for the recognized options to reduce
> the possibility of mis-spelling them then in the code at some point and
> thus failing silently; better to catch that at compile time.

Sounds good. I indeed based my work on the s390 options :) Since I did
the same for bridging, I will update those patches before the final
submission.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]