Re: [PATCH 0/2] firewall-manager update
- From: Dan Williams <dcbw redhat com>
- To: Thomas Woerner <twoerner redhat com>
- Cc: networkmanager-list gnome org
- Subject: Re: [PATCH 0/2] firewall-manager update
- Date: Fri, 10 Feb 2012 15:15:56 -0600
On Fri, 2012-02-10 at 20:28 +0100, Thomas Woerner wrote:
> Hello Jiri,
> On 02/10/2012 04:45 PM, Jiri Popelka wrote:
> > The first patch updates FirewallD DBus service& path& interface.
> > The second one adds calling of FirewallD1.zone.removeInterface method
> > during device deactivation.
> > Jiri Popelka (2):
> > firewall: update FirewallD DBus service& path& interface
> > firewall: add remove_from_zone()
> > src/firewall-manager/nm-firewall-manager.c | 80 ++++++++++++++++++++++-----
> > src/firewall-manager/nm-firewall-manager.h | 12 +++--
> > src/nm-device.c | 10 +++-
> > 3 files changed, 82 insertions(+), 20 deletions(-)
> that's great.
> One thing is still needed: If an interface gets renamed, the new
> interface has to be added first and the old one removed afterwards.
> Maybe there is a way to implement this in a simple way.
Well, that's the case for using ifindexes instead :( NM doesn't
interface renames right now, because it uses interface indexes for
everything that matters internally (except logs). Wouldn't be hard, and
would be good to do (listen for udev change events and update internal
] [Thread Prev