Re: libnm-glib 0.9 depends on glib 2.28 now



On Tue, 2012-02-07 at 11:25 +0100, Thomas Bechtold wrote:
> On Mon, 2012-02-06 at 15:14 -0500, Dan Winship wrote:
> > On 02/06/2012 11:45 AM, Dan Williams wrote:
> > >> 'g_simple_async_result_take_error' was introduced with commit 9fd98ef9
> > >> 'g_clear_object' was introduced with commit cc90f101
> > >>
> > >>
> > >> Was this intended?
> > > 
> > > I think so
> > 
> > Actually, I meant to stick with the current glib requirements, I just
> > forgot that take_error() was new-ish, and then the g_clear_object()
> > slipped by without me noticing.
> > 
> > Patch attached. I made a compat macro for take_error, since it's useful,
> > and just rewrote the one use of g_clear_object().
> > 
> > Oh, this is untested since I don't have a machine with old enough
> > glib... Thomas, can you try it?
> 
> there was one piece missing - G_VALUE_INIT. Patch attached. Now NM
> compiles with glib 2.24 (expect the gdbus example in examples/C/glib/
> but i just comment that.)

Pushed, thanks.

Dan



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]