Re: [PATCH] Make caching DNS server config files readable by everyone

[Dan Williams <dcbw redhat com>]

On Mon, 2012-01-30 at 11:59 -0800, Evan Broder wrote:
> All of the information in the configuration files for local caching
> dnsmasq or BIND servers are accessible already over the D-Bus
> interface, so there's no sensitive information here.

Pushed, thanks.

Dan

>  src/dns-manager/nm-dns-bind.c    |    2 +-
>  src/dns-manager/nm-dns-dnsmasq.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/dns-manager/nm-dns-bind.c b/src/dns-manager/nm-dns-bind.c
> index 55fce03..1a3243b 100644
> --- a/src/dns-manager/nm-dns-bind.c
> +++ b/src/dns-manager/nm-dns-bind.c
> @@ -413,7 +413,7 @@ update (NMDnsPlugin *plugin,
>  		g_clear_error (&error);
>  		goto out;
>  	}
> -	ignored = chmod (CONFFILE, 0600);
> +	ignored = chmod (CONFFILE, 0644);
>  
>  	nm_log_dbg (LOGD_DNS, "BIND local caching DNS configuration:");
>  	nm_log_dbg (LOGD_DNS, "%s", conf->str);
> diff --git a/src/dns-manager/nm-dns-dnsmasq.c b/src/dns-manager/nm-dns-dnsmasq.c
> index a602c54..e44513b 100644
> --- a/src/dns-manager/nm-dns-dnsmasq.c
> +++ b/src/dns-manager/nm-dns-dnsmasq.c
> @@ -294,7 +294,7 @@ update (NMDnsPlugin *plugin,
>  		g_clear_error (&error);
>  		goto out;
>  	}
> -	ignored = chmod (CONFFILE, 0600);
> +	ignored = chmod (CONFFILE, 0644);
>  
>  	nm_log_dbg (LOGD_DNS, "dnsmasq local caching DNS configuration:");
>  	nm_log_dbg (LOGD_DNS, "%s", conf->str);