[MM] [PATCH v2] iface-modem: fix crashes due to removed context
- From: Ben Chan <benchan chromium org>
- To: networkmanager-list gnome org
- Subject: [MM] [PATCH v2] iface-modem: fix crashes due to removed context
- Date: Wed, 1 Aug 2012 11:53:06 -0700
---
The issue doesn't seem to affect update_signa_quality.
src/mm-iface-modem.c | 14 ++++++++++----
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c
index e3165f2..f0fbb82 100644
--- a/src/mm-iface-modem.c
+++ b/src/mm-iface-modem.c
@@ -591,9 +591,12 @@ access_technologies_check_ready (MMIfaceModem *self,
} else
mm_iface_modem_update_access_technologies (self, access_technologies, mask);
- /* Remove the running tag */
+ /* Remove the running tag. Note that the context may have been removed by
+ * mm_iface_modem_shutdown when this function is invoked as a callback of
+ * load_access_technologies. */
ctx = g_object_get_qdata (G_OBJECT (self), access_technologies_check_context_quark);
- ctx->running = FALSE;
+ if (ctx)
+ ctx->running = FALSE;
}
static gboolean
@@ -843,9 +846,12 @@ signal_quality_check_ready (MMIfaceModem *self,
} else
update_signal_quality (self, signal_quality, TRUE);
- /* Remove the running tag */
+ /* Remove the running tag. Note that the context may have been removed by
+ * mm_iface_modem_shutdown when this function is invoked as a callback of
+ * load_signal_quality. */
ctx = g_object_get_qdata (G_OBJECT (self), signal_quality_check_context_quark);
- ctx->running = FALSE;
+ if (ctx)
+ ctx->running = FALSE;
}
static gboolean
--
1.7.7.3
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]