[PATCH 6/6] setting_template: update to best practices
- From: Dominik Sommer <dominik sommer name>
- To: networkmanager-list gnome org
- Subject: [PATCH 6/6] setting_template: update to best practices
- Date: Mon, 16 Apr 2012 14:33:42 +0200
---
libnm-util/nm-setting-template.c | 26 +++-
libnm-util/nm-setting-template.h | 3 +
diff --git a/libnm-util/nm-setting-template.c
b/libnm-util/nm-setting-template.c
index dc3e420..c2de954 100644
--- a/libnm-util/nm-setting-template.c
+++ b/libnm-util/nm-setting-template.c
@@ -29,8 +29,30 @@
#include "nm-setting-template.h"
+/**
+ * nm_setting_template_error_quark:
+ *
+ * Registers an error quark for #NMSettingTemplate if necessary.
+ *
+ * Returns: the error quark used for #NMSettingTemplate errors.
+ **/
+GQuark
+nm_setting_template_error_quark (void)
+{
+ static GQuark quark;
+
+ if (G_UNLIKELY (!quark))
+ quark = g_quark_from_static_string
("nm-setting-template-error-quark");
+ return quark;
+}
+
G_DEFINE_TYPE (NMSettingTemplate, nm_setting_template, NM_TYPE_SETTING)
+#define NM_SETTING_TEMPLATE_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE
((o), NM_TYPE_SETTING_TEMPLATE, NMSettingTemplatePrivate))
+
+typedef struct {
+} NMSettingTemplatePrivate;
+
enum {
PROP_0,
@@ -44,7 +66,7 @@ nm_setting_template_new (void)
}
static gboolean
-verify (NMSetting *setting, GSList *all_settings)
+verify (NMSetting *setting, GSList *all_settings, GError **error)
{
NMSettingTemplate *self = NM_SETTING_TEMPLATE (setting);
return TRUE;
@@ -96,6 +118,8 @@ nm_setting_template_class_init
(NMSettingTemplateClass *setting_class)
GObjectClass *object_class = G_OBJECT_CLASS (setting_class);
NMSettingClass *parent_class = NM_SETTING_CLASS (setting_class);
+ g_type_class_add_private (setting_class, sizeof
(NMSettingTemplatePrivate));
+
/* virtual methods */
object_class->set_property = set_property;
object_class->get_property = get_property;
diff --git a/libnm-util/nm-setting-template.h
b/libnm-util/nm-setting-template.h
index 2ec2cf3..410c495 100644
--- a/libnm-util/nm-setting-template.h
+++ b/libnm-util/nm-setting-template.h
@@ -43,6 +43,9 @@ G_BEGIN_DECLS
#define NM_SETTING_TEMPLATE_SETTING_NAME "template"
+#define NM_SETTING_TEMPLATE_ERROR nm_setting_template_error_quark ()
+GQuark nm_setting_template_error_quark (void);
+
typedef struct {
NMSetting parent;
} NMSettingTemplate;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]