Re: [PATCH 0/5] Second round of Network Zones support

[Dan Williams <dcbw redhat com>]

On Fri, 2011-10-07 at 15:58 +0200, Jiri Popelka wrote:
> Would be great if somebody could review them. But there's
> no hurry cause I'm away whole next week.

These all look fine aside from some small cosmetic cleanups I'll do when
I commit.

Thanks!
Dan

> Jiri Popelka (5):
>   New 'zone' property of the NMSettingConnection.
>   plugins/ifcfg-rh: read/write zone name from/to ZONE key
>   nmcli: add zone field to 'con status'
>   Firewall manager
>   NMPolicy: let firewall know about the zone when connection gets
>     updated
> 
>  cli/src/connections.c                      |    4 +-
>  configure.ac                               |    1 +
>  libnm-util/libnm-util.ver                  |    1 +
>  libnm-util/nm-setting-connection.c         |   52 ++++++
>  libnm-util/nm-setting-connection.h         |    9 +
>  src/Makefile.am                            |    3 +
>  src/firewall-manager/Makefile.am           |   26 +++
>  src/firewall-manager/nm-firewall-manager.c |  233 ++++++++++++++++++++++++++++
>  src/firewall-manager/nm-firewall-manager.h |   63 ++++++++
>  src/firewall-manager/nm-firewall-types.h   |   26 +++
>  src/main.c                                 |   12 ++
>  src/nm-device.c                            |   75 +++++++++-
>  src/nm-policy.c                            |   60 +++++++-
>  src/settings/plugins/ifcfg-rh/reader.c     |   12 ++-
>  src/settings/plugins/ifcfg-rh/writer.c     |    2 +
>  15 files changed, 571 insertions(+), 8 deletions(-)
>  create mode 100644 src/firewall-manager/Makefile.am
>  create mode 100644 src/firewall-manager/nm-firewall-manager.c
>  create mode 100644 src/firewall-manager/nm-firewall-manager.h
>  create mode 100644 src/firewall-manager/nm-firewall-types.h
>