Re: [PATCH] remove AP always on device disconnect

[Ludwig Nussel <ludwig nussel suse de>]

Dan Williams wrote:
> On Fri, 2011-10-07 at 15:21 +0200, Ludwig Nussel wrote:
>> This avoids immediate reconnect after link timeout to an AP that may no longer exist (down/out of range). This also avoids needless prompting for a password for the no longer existing AP.
> 
> This could work, but I think we need to restrict the AP removal to cases
> where the supplicant times out after we've already been successfully
> connected, which is basically the case you're talking about.  For
> example, in the case of an explicit disconnect (via the menu item or
> D-Bus call) we'd remove a perfectly good AP and might not find it again
> until the next scan happened a few minutes after the disconnect.

Yes. Is there a way to find out whether the request was triggered by
an event from wpa_supplicant or by the user?

> Maybe instead of doing it during deactivate, remove the AP in
> supplicant_connection_timeout_cb() right before moving to the
> DISCONNECTED state?

Doesn't that callback trigger too late? Ie after NM has already
prompted for a new password?

cu
Ludwig

-- 
 (o_   Ludwig Nussel
 //\
 V_/_  http://www.suse.de/
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)