Re: [PATCH 4/8] bonding: Detect virtual bonding devices and create an ethernet device

[Dan Williams <dcbw redhat com>]

On Mon, 2011-11-07 at 17:28 +0100, Thomas Graf wrote:
> On Mon, 2011-11-07 at 16:51 +0100, Thomas Graf wrote:
> > However, the reason I dup in nm_system_get_link_type() is because due to
> > the returning of the link reference there is a theoretical chance that
> > the module which is behind the link type will be unloaded. libnl
> > currently does not do so but that might happen in the future.
> > 
> > It might be better to compare the return type against a list of known
> > link types by NM and return a pointer to a type string owned by NM
> > memory. Thoughts?
> 
> Actually, I just changed this to returning an enum thus following your
> initial suggestion.

Great, sounds fine, saves a memdup() too.

Dan