Re: [Linux-ATM-General] [PATCH 2/3] ADSL: Carrier Handling and PPP support

[chas williams - CONTRACTOR <chas cmf nrl navy mil>]

On Sat, 28 May 2011 12:55:25 +0100
David Woodhouse <dwmw2 infradead org> wrote:

> However, it's not clear how we're then supposed to work out what name it
> created for us. Perhaps we need something like...

this would be the best choice IMO.  just choose the name you want to
create.  if it fails, you will need to pick another like 'nas1'.  you
can always not use the nas prefix to prevent collision with other
br2684 users who are likely relying on the default interface names.

> Strictly speaking, that's an ABI change for an existing ioctl, and thus
> quite naughty. But since I don't think there *are* currently any users
> of that ioctl outside br2684ctl, I suspect we'd get away with it...

i think you might need to change the ioctl from _IOW() to _IOWR() as
well.  this would change the ioctl number i think and create more
trouble than you would like.