Re: [PATCH 0/3] [RFC] Support for ADSL modems

On Mon, May 9, 2011 at 9:38 PM, Dan Williams <dcbw redhat com> wrote:
> On Fri, 2011-05-06 at 14:23 +0300, Pantelis Koukousoulas wrote:
>> Hi, before I leave for, this patch series implements the initial
>> version of the support for ADSL modems in network manager.
>> Notes:
>>    * PPPoA-only for now. I hope that PPPoE can be added with not too much trouble
>>      as well, if it is possible to just create a new ethernet device for the "nas0"
>>      interface that br2684ctl creates and reuse the already existing "wired" device
>>      PPPoE support.
>>      This way the adsl part can manage the ATM part of the equation just like it
>>      does now for PPPoA.
> Well, the PPPoE bits aren't that complicated, so for now I'd rather
> duplicate them for the ADSL code, and we can re-merge it later.  Most of
> the code is simply detecting whether PPPoE should be used, and if so,
> creating a new NMPPPManager object for the interface, then connecting to
> the signals that it provides.

The thing is that br2684ctl creates a device that is indistinguishable from
an ethernet interface from what I can tell. So, probably udev and netlink
will report it as an ethernet device, NetworkManager will configure it
for PPPoE and everything will be ok? (in theory at least).

> But lets get PPPoA working first and PPPoE can come later.

Agreed, let's wait and see how it will work in practice.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]