Re: [nm-applet][0.8.4][PATCH] trivial: fix possible uninitialized variable usage



Am Montag, den 09.05.2011, 15:08 -0500 schrieb Dan Williams:
> On Mon, 2011-05-09 at 21:50 +0200, Paul Menzel wrote:
> > Am Montag, den 09.05.2011, 13:17 -0500 schrieb Dan Williams:

[…]

> > > Yeah, that got fixed in commit bbe547f7985498e0bc353ccd2e8e6f9a4a89249b
> > > right after 0.8.4 was released;
> > 
> > Strange.
> > 
> > I cherry picked 
> > 
> >         commit cc472cea1021dee90714703380a79e326aa0e681
> >         Author: Dan Williams <dcbw redhat com>
> >         Date:   Thu Jan 27 10:59:37 2011 -0600
> >         
> >             trivial: fix possible uninitialized variable usage
> > 
> > which seems to address the exact same issues. Do you know why I cannot
> > find the commit you referenced in any branch?
> > 
> >         $ git branch --contains cc472cea1021dee90714703380a79e326aa0e681
> >           master
> >         $ git branch --contains bbe547f7985498e0bc353ccd2e8e6f9a4a89249b
> >         $ git --version
> >         git version 1.7.5.1
> 
> It's on the NMA_0_8 branch, which is the stable 0.8.x series branch.  Do
> you have that branched locally?  That could be the issue though I don't
> know why;
> 
> http://git.gnome.org/browse/network-manager-applet/commit/?h=NMA_0_8&id=bbe547f7985498e0bc353ccd2e8e6f9a4a89249b

You are right, I did not have a local checkout. `-a` comes to the
rescue.

        $ git branch -a --contains
        bbe547f7985498e0bc353ccd2e8e6f9a4a89249b
          remotes/origin/NMA_0_8


Thanks,

Paul

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]