Am 19.03.2011 20:16, schrieb Dan Williams: > VPN plugins to follow. Thanks to everyone so far for their testing, > lets keep at it til we're done. Areas of interest are WiFi scanning A few issues I found while testing the 0.8.997 tarball (on Debian sid, GCC 4.5, i386) 1/ it fails to build with --enable-more-warnings (due to -Werror) libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../.. -I../../include -I../../marshallers -I../../src/logging -I../../libnm-util -I../../src -pthread -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -DG_DISABLE_DEPRECATED -DLIBEXECDIR=\"/usr/local/libexec\" -DLOCALSTATEDIR=\"/usr/local/var\" -DDHCLIENT_PATH=\"/sbin/dhclient\" -DDHCPCD_PATH=\"\" -Wall -Werror -std=gnu89 -g -O2 -Wshadow -Wmissing-declarations -Wmissing-prototypes -Wdeclaration-after-statement -Wfloat-equal -Wno-unused-parameter -Wno-sign-compare -fno-strict-aliasing -Wno-unused-but-set-variable -MT libdhcp_manager_la-nm-dhcp-manager.lo -MD -MP -MF .deps/libdhcp_manager_la-nm-dhcp-manager.Tpo -c nm-dhcp-manager.c -fPIC -DPIC -o .libs/libdhcp_manager_la-nm-dhcp-manager.o cc1: warnings being treated as errors nm-dhcp-manager.c: In function 'nm_dhcp_manager_handle_event': nm-dhcp-manager.c:238:3: error: format '%zd' expects type 'signed size_t', but argument 6 has type 'long unsigned int' nm-dhcp-manager.c:243:3: error: format '%zd' expects type 'signed size_t', but argument 6 has type 'long unsigned int' nm-dhcp-manager.c:250:3: error: format '%zd' expects type 'signed size_t', but argument 6 has type 'long unsigned int' At top level: cc1: error: unrecognized command line option "-Wno-unused-but-set-variable" make[5]: *** [libdhcp_manager_la-nm-dhcp-manager.lo] Error 1 make[5]: Leaving directory `/tmp/NetworkManager-0.8.997/src/dhcp-manager' 2/ make check fails for the python scripts This is because on Debian we use /usr/bin/env, not /bin/env. I've sent Dan a patch for this already 3/ building the documentation (--with-docs) fails to link in libnm-glib gtk-doc: Linking scanner libtool: link: gcc -g -O2 .libs/libnm-glib-scan.o -pthread -o .libs/libnm-glib-scan ../../libnm-glib/.libs/libnm-glib.so /tmp/NetworkManager-0.8.997/libnm-util/.libs/libnm-util.so -luuid -lnss3 -lnssutil3 -lsmime3 -lssl3 -lplds4 -lplc4 -lnspr4 -ldl -ldbus-glib-1 -ldbus-1 -lpthread -lgudev-1.0 /usr/lib/libgobject-2.0.so /usr/lib/libgthread-2.0.so -lrt /usr/lib/libglib-2.0.so -pthread /usr/bin/ld: .libs/libnm-glib-scan.o: in function main:libnm-glib-scan.c:77: error: undefined reference to 'nm_vpn_plugin_error_get_type' /usr/bin/ld: .libs/libnm-glib-scan.o: in function main:libnm-glib-scan.c:78: error: undefined reference to 'nm_vpn_plugin_get_type' /usr/bin/ld: .libs/libnm-glib-scan.o: in function main:libnm-glib-scan.c:79: error: undefined reference to 'nm_vpn_plugin_ui_interface_get_type' /usr/bin/ld: .libs/libnm-glib-scan.o: in function main:libnm-glib-scan.c:80: error: undefined reference to 'nm_vpn_plugin_ui_widget_interface_get_type' collect2: ld returned 1 exit status Linking of scanner failed: make[3]: *** [scan-build.stamp] Error 1 make[3]: Leaving directory `/tmp/NetworkManager-0.8.997/docs/libnm-glib' It's interesting to note, that if I build directly from git and use autogen.sh, I don't get this link failures. Maybe this is related du to the fact that on Debian I have gtk-doc 1.17, whereas the buildsystem of the 0.8.997 tarballs seems to use gtk-doc 1.18. Haven't further investigated yet. 4/ soname of libnm-glib was bumped (I assume because of the removal of nm_ip4_config_get_hostname() Do you plan further changes to the API for 0.9? If so, only additions or also incompatible ones with further soname bumps? If you prefer separate bug reports for these issues, let me know. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
Attachment:
signature.asc
Description: OpenPGP digital signature