Re: [PATCH] settings: add support for mac-blacklists for wifi and ethernet

[Jirka Klimes <jklimes redhat com>]

On Tuesday 21 of June 2011 07:03:55 Dan Williams wrote:
> On Fri, 2011-06-17 at 00:04 +0200, Thomas Bechtold wrote:
> > Hi,
> > 
> > i missed the blacklist check in real_check_connection_compatible() for
> > ethernet and wifi. Patch attached.
> 
> Looks good; in the future we should have get_best_auto_connection() call
> check_connection_compatible() and remove the redundant code; but we
> dont' have to do that now.  Jiri can you test these, squash them into
> one with git rebase -i or something and push them?  I'm on vacation for
> a bit.
> 

Thanks for the patches!

I've tested the feature. I needed to update the patches a bit. It crashed when 
the address matched the list ;) 'cause no error was set. I've fixed that and 
done other minor tweaks too.

Pushed to NM_0_8 branch: ed5cd006cbe04beeabef85dbe44a7c443c7fe91a

Jirka


> Thanks!
> Dan
> 
> > Cheers,
> > 
> > Tom
> > 
> > On Thu, 2011-06-16 at 23:41 +0200, Thomas Bechtold wrote:
> > > Hi,
> > > 
> > > i created a patch to support MAC address blacklists for Ethernet/Wifi
> > > connections. With this patch it's possible to disable a connection for
> > > a given list of mac-addresses.
> > > 
> > > I created this patch for the NM 0.8 branch and i have not tested this
> > > for 0.9 and i don't know if it's difficult to port this patch to NM
> > > 0.9.
> > > 
> > > Cheers,
> > > 
> > > Tom