Re: [PATCH] ModemManager: Enhancements to Icera error reporting and access technology reporting

[Dan Williams <dcbw redhat com>]

On Tue, 2011-06-07 at 10:35 -0400, Eric Shienbrood wrote:
> Thanks Aleksander! New patch file is attached.

I split these up and pushed all hunks except the hunk for processing the
match info for the NWSTATE response.  Two things there... first you need
to make sure you free the result of g_match_info_fetch() since that's an
allocated string.  Second, what does '-' mean again for the <connected>
field?  I had the docs at some point but I appear to have lost them;
what other values can be there, and why don't we want to update the
access technology when that field is something other than '-'?

Thanks!
Dan

> Eric
> 
> 
> 
> On Tue, Jun 7, 2011 at 2:56 AM, Aleksander Morgado
> <aleksander lanedo com> wrote:
>         Hi Eric,
>         
>         
>         > The additional error detail allows us to know that a
>         connection failed
>         > because of an invalid APN. Also, when handling access
>         technology
>         > changes, report the technology in use if we're connected.
>         Finally,
>         > avoid using CFUN=0 when disabling the modem.
>         
>         
>         A small thing to fix in the patch.
>         
>         All callbacks receiving a response from the AT serial port
>         should check
>         if the modem has already been removed, so in
>         query_network_error_code_done(), this check is needed just
>         before trying
>         to parse any reply:
>         
>            /* If the modem has already been removed, return without
>             * scheduling callback */
>            if (mm_callback_info_check_modem_removed (info))
>                return;
>         
>         See
>         http://cgit.freedesktop.org/ModemManager/ModemManager/commit/?id=9323daec015ecad65c39b6020b62e864c027d858
>         
>         Cheers!
>         
>         --
>         Aleksander
>         
> 
> 
> _______________________________________________
> networkmanager-list mailing list
> networkmanager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list