Re: [PATCH 0/7] bonding updates v2

[Dan Williams <dcbw redhat com>]

On Tue, 2011-11-22 at 12:19 +0100, Thomas Graf wrote:
> Revised set of bonding updates with Dan's comments addressed. This
> is currently based on top of the cleanup patches I have posted
> yesterday.
> 
> The main focus is on getting the connection to device matching right
> to correctly reassume devices and allow manipulating bonding
> connections via the CLI.
> 
> It also improves carrier handling of bonding masters to allow
> auto activation of bonding masters.

Aside from my comments on patch 1, the rest look good.  I'll merge ipoib
and devplugins and then when a rebase of this series shows up, push the
rebase.  Thanks!

Dan

> Thomas Graf (7):
>   bonding: Add nm_connection_get_virtual_iface_name() to abstract
>     kernel interface binding
>   ethernet: Check kernel interface binding when matching config
>   ethernet: Move all connection <-> device matching into a single
>     function
>   ethernet: Allow devices to be reassumed when ip4 config is disabled
>   cli: Move ethernet connection matching to libnm-glib and add bonding
>     support
>   bonding: Log slave activation/deactivation
>   bonding: Move bonding master state to UNAVAILABLE regardless of
>     carrier state
> 
>  cli/src/connections.c           |   60 +--------
>  libnm-glib/libnm-glib.ver       |    1 +
>  libnm-glib/nm-device-ethernet.c |   61 ++++++--
>  libnm-glib/nm-device-ethernet.h |    2 +
>  libnm-util/libnm-util.ver       |    3 +
>  libnm-util/nm-connection.c      |   51 +++++++
>  libnm-util/nm-connection.h      |    4 +
>  libnm-util/nm-setting-bond.c    |    9 +
>  libnm-util/nm-setting.c         |   20 +++
>  libnm-util/nm-setting.h         |    5 +-
>  src/nm-device-ethernet.c        |  314 ++++++++++++++++-----------------------
>  src/nm-device.c                 |   10 ++
>  src/settings/nm-settings.c      |    7 +-
>  13 files changed, 286 insertions(+), 261 deletions(-)
>