Re: Patch: Wildcard for no-auto-default.

[Dan Williams <dcbw redhat com>]

On Thu, 2010-09-16 at 18:24 +0200, Jirka Klimes wrote:
> On Friday 09 of July 2010 18:59:08 Pat Suwalski wrote:
> > Hello,
> > 
> > I had a request a few weeks back about how to get the system settings
> > daemon to ignore all cards without hardcoding MAC addresses into the
> > nm-system-settings.conf file. It was mentioned that there's a workaround
> > for RedHat-based systems. I wanted something more explicit.
> > 
> > The attached trivial patch lets the user specify "no-auto-default=*" to
> > have all of the connections blacklisted by the system settings daemon.
> > 
> > --Pat
> 
> Strictly speaking, "no-auto-default" option doesn't cause ignoring devices. 
> Rather it is used to specify that for a device, NM shouldn't create a default 
> wired connection (Auto eth0), which is normally done for all managed devices 
> that doesn't any connection.
> 
> If you would have a connection with 'autoconnect=true' that applies to a 
> device, listing the device in "no-auto-default" doesn't prevent the device 
> from being activated.
> 
> Nevertheless, I think it's a good feature to support glob. And in case you 
> didn't configure a connection manually, it will solve your issue.
> 
> I've updated a patch a bit not to add the MAC to the list when "*" is already 
> there. And to ignore leading and trailing whitespaces.
> 
> Dan, are you for the patch?

Sure, though a mild style change.  Instead of:

if (foo)
{
   ...
}

lets do:

if (foo) {
   ...
}


Thanks!
Dan