Re: parent (GUdevDevice) uninitialized in _update_s390_subchannels

[Dan Williams <dcbw redhat com>]

On Thu, 2010-11-04 at 15:40 -0400, Mathieu Trudel-Lapierre wrote:
> Hi,
> 
> I noticed NM fails to build on Ubuntu Natty:

Pushed, thanks.

Dan

> gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../include -I../marshallers
> -I../src/logging -I../src/dns-manager -I../src/vpn-manager
> -I../src/dhcp-manager -I../src/ip6-manager -I../src/supplicant-manager
> -I../src/dnsmasq-manager -I../src/modem-manager -I../src/bluez-manager
> -I../src/system-settings -I../libnm-util -I../libnm-glib -I../callouts
> -pthread -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include
> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -pthread
> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -pthread
> -I/usr/include/gudev-1.0 -I/usr/include/glib-2.0
> -I/usr/lib/glib-2.0/include    -pthread -I/usr/include/glib-2.0
> -I/usr/lib/glib-2.0/include   -pthread -I/usr/include/polkit-1
> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
> -DG_DISABLE_DEPRECATED -DBINDIR=\"/usr/bin\" -DSBINDIR=\"/usr/sbin\"
> -DLIBEXECDIR=\"/usr/lib/NetworkManager\" -DDATADIR=\"/usr/share\"
> -DSYSCONFDIR=\"/etc\" -DLOCALSTATEDIR=\"/var\" -DNM_RUN_DIR=
> \"/var/run/NetworkManager\" -DNMLOCALEDIR=\"/usr/share/locale\"
> -DARP_DEBUG   -Wall -Werror -std=gnu89 -g -O2 -g -Wall -O2 -Wshadow
> -Wmissing-declarations -Wmissing-prototypes
> -Wdeclaration-after-statement -Wfloat-equal -Wno-unused-parameter
> -Wno-sign-compare -fno-strict-aliasing -c -o
> NetworkManager-nm-device-ethernet.o `test -f 'nm-device-ethernet.c' ||
> echo './'`nm-device-ethernet.c
> cc1: warnings being treated as errors
> nm-device-ethernet.c: In function ‘constructor’:
> nm-device-ethernet.c:400:5: error: ‘parent’ may be used uninitialized in
> this function
> nm-device-ethernet.c:311:15: note: ‘parent’ was declared here
> make[5]: *** [NetworkManager-nm-device-ethernet.o] Erreur 1
> make[5]: quittant le répertoire
> « /home/mtrudel/Projects/ubuntu/build-area/network-manager-0.8.2/src »
> make[4]: *** [all-recursive] Erreur 1
> make[4]: quittant le répertoire
> « /home/mtrudel/Projects/ubuntu/build-area/network-manager-0.8.2/src »
> make[3]: *** [all] Erreur 2
> make[3]: quittant le répertoire
> « /home/mtrudel/Projects/ubuntu/build-area/network-manager-0.8.2/src »
> make[2]: *** [all-recursive] Erreur 1
> make[2]: quittant le répertoire
> « /home/mtrudel/Projects/ubuntu/build-area/network-manager-0.8.2 »
> make[1]: *** [all] Erreur 2
> make[1]: quittant le répertoire
> « /home/mtrudel/Projects/ubuntu/build-area/network-manager-0.8.2 »
> make: *** [debian/stamp-makefile-build] Erreur 2
> 
> Attached is the patch I applied.
> 
> _______________________________________________
> networkmanager-list mailing list
> networkmanager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list