Re: parent (GUdevDevice) uninitialized in _update_s390_subchannels

[Marc Herbert <Marc Herbert gmail com>]

>> `nm-device-ethernet.c
>> cc1: warnings being treated as errors
>> nm-device-ethernet.c: In function ‘constructor’:
>> nm-device-ethernet.c:400:5: error: ‘parent’ may be used uninitialized in
>> this function
> 
> Attached is the patch I applied:
> 
> -	GUdevDevice *parent;
> +	GUdevDevice *parent = NULL; // disable gcc warning because...?
> 
> 
> This just buries the warning. Are you sure the warning is wrong? If yes it deserves a comment.

The proper way to get rid of this warning is not to group declarations at the top of the block:

<http://stackoverflow.com/questions/288441/variable-declaration-placement-in-c/4105334#4105334>