Re: No error is returned to user if system settings plugin fails connection update



On Tuesday 02 of March 2010 10:14:09 Dan Williams wrote:
> On Sat, 2010-02-27 at 23:39 +0300, Andrey Borzenkov wrote:
> > Using NM 0.8 + nm-applet 0.8 I hit the following situation - if
> > ->update plugin method fails (for whatever reason - e.g. plugin is
> > not able to create necessary file) - no error is returned to user.
> > Error is correctly returned if creation of new system connection
> > fails.
> > 
> > I start nm-connection-editor and select system connection to
> > modify. I correctly get authentication request and am able to
> > modify connection (and save changes if no errors happened). But if
> > there are errors inside of plugin during updating of connection
> > settings, very funny situation results - logical state of NM is
> > updated (i.e. if I start n-c-e again, I see my changes) but state
> > in files on permanent storage is not updated, meaning restarting
> > NM show again previous configuration.
> > 
> > I verified that plugin really returns error, error is correctly set
> > and plugin should be calling callback (in this case
> > con_update_cb). This unfortunately pretty much ends my ability to
> > debug it further - I am not good at D-Bus internals.
> 
> So the flow *does* get to nm-sysconfig-connection.c's con_update_cb()
> function,

Yes

> and the error is valid in that function?  

Yes

> If you add a
> g_message/fprintf of error->message there is that valid too?
> 

update: DEBUG: /etc/sysconfig/network-scripts/ifcfg-eth0 ERROR ifcfg-
mdv: DHCP_CLIENT_ID is not supported
con_update_cb: DEBUG: connection error ifcfg-mdv: DHCP_CLIENT_ID is not 
supported

Attachment: signature.asc
Description: This is a digitally signed message part.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]