Re: [PATCH] add UnlockRetries property to the modem dbus interface

[Torgny Johansson <torgny johansson gmail com>]

>>
>> Pushed.
>
> Thank you!
>
> Then we also need to address the issue that the UnlockRequired and UnlockRetries properties don't get updated if you enter an invalid pin code. That was the reason for the change (removed the return on error) I did in send_pin_done in the original patch.
>
> The issue is that when you enter the wrong pin code, the modem returns ERROR. In send_pin_done that means that the error will be set, the callback scheduled and the function then returns without running check_pin which would update the state of UnlockRequired and UnlockRetries.

Just a reminder about the issue mentioned above :)

Any comments on it?

Thanks

/Torgny