Re: [PATCH] Easy patch (help out!): preserve wireless-enabled and networking-enabled

[Jirka Klimes <jklimes redhat com>]

On Tuesday 27 October 2009 15:04:51 Tony Espy wrote:
> On 10/27/2009 07:58 AM, Jirka Klimes wrote:
> > On Friday 23 October 2009 19:19:14 Dan Williams wrote:
> >> Anyone want to do a really simple patch?  It would close some bugs and
> >> help out a lot:
> >
> > Hello Dan,
> >
> > I've done the patch. Please, review it.
> 
> Jirka --
> 
> You beat me to the punch...  I finished up my version last night, but
> hadn't tested it yet.
> 

Sorry for that. I hope you didn't spend much time on it.
Nevertheless it's good when more people check the stuff.

> You version is actually a little bit cleaner, as I hadn't created a new
> struct for the config parameters.  I've attached my version ( which is
> actually a quilt patch for Ubuntu ) for reference.
> 
> The one thing I think you may have missed, is checking for
> G_KEY_FILE_ERROR_INVALID_VALUE when reading the values from the file.
> Other than that, looks good to me!
> 

I'm aware of G_KEY_FILE_ERROR_INVALID_VALUE. However I decided not to produce 
errors for reading the values.
So:
missing keys -         regarded as TRUE
erroneous values - regarded as FALSE

That's why no handling of G_KEY_FILE_ERROR_INVALID_VALUE.
But the behaviour can of course be changed if this is not what we want.

> Regards,
> /tony
> 
> > NetworkingEnabled and WirelessEnabled are read from config file. If not
> > present, the values are regarded as true; if case of mangled values (or
> > something), false is used.
> > On changing values in the applet, the keys are changed (created)
> > in the cofiguration file.
> >
> > Jirka
> >