Re: Bug/Patch

[Dan Williams <dcbw redhat com>]

On Fri, 2009-02-06 at 15:28 -0700, Russell Suter wrote:
> All,
> 
> Apologies up front if this isn't proper procedure for submitting a 
> patch, but I'm still new.

No problem; you've hit the correct procedure on the first try :)

> There is a slight annoyance/bug in the advanced page of the pptp setup 
> page.  If one selects MPPE and chooses 128 bit, the next time they come 
> into the screen, the MPPE check box is not set.  This is because the 
> require-mppe key is not set.  The following patch will always set the 
> require-mppe key if the check box is set:

Committed as revision 21 (trunk) and 22 (stable 0.7).

One nit: the patch is word-wrapped, so it wouldn't apply directly.
Usually your mail program will have a way to mark a block of text as
"Preformatted" or something like that, which is always good to do with
patches.

Thanks!
Dan

> Index: advanced-dialog.c
> ===================================================================
> --- advanced-dialog.c    (revision 19)
> +++ advanced-dialog.c    (working copy)
> @@ -385,10 +385,11 @@
>              g_hash_table_insert (hash, g_strdup 
> (NM_PPTP_KEY_REQUIRE_MPPE_40), g_strdup ("yes"));
>              break;
>          default:
> -            g_hash_table_insert (hash, g_strdup 
> (NM_PPTP_KEY_REQUIRE_MPPE), g_strdup ("yes"));
>              break;
>          }
>  
> +        g_hash_table_insert (hash, g_strdup (NM_PPTP_KEY_REQUIRE_MPPE), 
> g_strdup ("yes"));
> +
>          widget = glade_xml_get_widget (xml, "ppp_allow_stateful_mppe");
>          if (gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (widget)))
>              g_hash_table_insert (hash, g_strdup 
> (NM_PPTP_KEY_MPPE_STATEFUL), g_strdup ("yes"));
> 
> This may not be the best way to fix the problem, but it does work.
> 
> --
> Russ
> _______________________________________________
> NetworkManager-list mailing list
> NetworkManager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list