Re: Current master is broken

[Dan Williams <dcbw redhat com>]

On Mon, 2009-08-24 at 11:21 +0300, Ozan Çağlayan wrote:
> gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../include -I../marshallers
> -I../src/named-manager -I../src/vpn-manager -I../src/dhcp-manager
> -I../src/supplicant-manager -I../src/dnsmasq-manager
> -I../src/modem-manager -I../src/bluez-manager -I../src/system-settings
> -I../libnm-util -I../libnm-glib -I../callouts -I/usr/include/dbus-1.0
> -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0
> -I/usr/lib/glib-2.0/include   -lpthread -I/usr/include/glib-2.0
> -I/usr/lib/glib-2.0/include    -I/usr/include/gudev-1.0
> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include    
> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  
> -DG_DISABLE_DEPRECATED -DBINDIR=\"/usr/bin\" -DSBINDIR=\"/usr/sbin\"
> -DLIBEXECDIR=\"/usr/libexec\" -DDATADIR=\"/usr/share\"
> -DSYSCONFDIR=\"/usr/etc\" -DLOCALSTATEDIR=\"/usr/var\"
> -DNM_RUN_DIR=\"/usr/var/run/NetworkManager\"
> -DNMLOCALEDIR=\"/usr/share/locale\" -DARP_DEBUG   -Wall -Werror
> -std=gnu89 -g -O2 -Wshadow -Wmissing-declarations -Wmissing-prototypes
> -Wdeclaration-after-statement -Wfloat-equal -Wno-unused-parameter
> -Wno-sign-compare -fno-strict-aliasing -MT NetworkManager-nm-logging.o
> -MD -MP -MF .deps/NetworkManager-nm-logging.Tpo -c -o
> NetworkManager-nm-logging.o `test -f 'nm-logging.c' || echo
> './'`nm-logging.c
> 
> cc1: warnings being treated as errors
> nm-logging.c: In function 'fallback_get_backtrace':
> nm-logging.c:57: error: format '%lx' expects type 'long unsigned int',
> but argument 6 has type 'int'
> nm-logging.c:63: error: format '%lx' expects type 'long unsigned int',
> but argument 6 has type 'int'

Dan Winship pushed a fix for this late yesterday.  Thanks for the
heads-up.

Dan


> which is caused by:
> 
> commit 09459788cdf5543dcdb296652475ef4afd59ad1e
> Author: Dan Williams <dcbw redhat com>
> Date:   Fri Aug 21 12:16:17 2009 -0500
> 
>     core: don't use backtrace_symbols() from a signal handler
> 
>     It uses malloc(), which you can't do from a signal handler.
> 
> 
> Regards,
> Ozan
> _______________________________________________
> NetworkManager-list mailing list
> NetworkManager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list