Re: nm-applet svn 938

[Dan Williams <dcbw redhat com>]

On Fri, 2008-10-10 at 16:46 +0200, Grant Williamson wrote:
> Actually I think it was caused by one of the fedora 9 4022 patches.

You're probably right, just comment out the "no-system-connections"
patch in the specfile.  That'll be killed once system connection editing
works correctly.

Dan

> n_editor-nm-connection-editor.o `test -f 'nm-connection-editor.c' || 
> echo './'`nm-connection-editor.c
> nm-connection-editor.c: In function 'nm_connection_editor_save_vpn_secrets':
> nm-connection-editor.c:421: error: 'system' undeclared (first use in 
> this function)
> nm-connection-editor.c:421: error: (Each undeclared identifier is 
> reported only once
> nm-connection-editor.c:421: error: for each function it appears in.)
> make[4]: *** [nm_connection_editor-nm-connection-editor.o] Error 1
> make[4]: Leaving directory 
> `/mnt/mirror/DEFAULTS-OLD/redhat-rhel4/BUILD/NetworkManager-0.7.0/nm-applet-0.7.0/src/connection-editor'
> make[3]: *** [all] Error 2
> make[3]: Leaving directory 
> `/mnt/mirror/DEFAULTS-OLD/redhat-rhel4/BUILD/NetworkManager-0.7.0/nm-applet-0.7.0/src/connection-editor'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory 
> `/mnt/mirror/DEFAULTS-OLD/redhat-rhel4/BUILD/NetworkManager-0.7.0/nm-applet-0.7.0/src'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory 
> `/mnt/mirror/DEFAULTS-OLD/redhat-rhel4/BUILD/NetworkManager-0.7.0/nm-applet-0.7.0'
> make: *** [all] Error 2
> 
> 
> 
> Dan Williams wrote:
> > On Fri, 2008-10-10 at 16:06 +0200, Grant Williamson wrote:
> >   
> >> Currently does not build for me, need to add.
> >>     
> >
> > Hmm, what's the error you're hitting?  That doesn't look like it should
> > make a difference to that function...
> >
> > Dan
> >
> >   
> >> diff -ur 
> >> nm-applet-0.7.0.orig/src/connection-editor/nm-connection-editor.c 
> >> nm-applet-0.7.0/src/connection-editor/nm-connection-editor.c
> >> --- nm-applet-0.7.0.orig/src/connection-editor/nm-connection-editor.c    
> >> 2008-10-10 15:56:09.000000000 +0200
> >> +++ nm-applet-0.7.0/src/connection-editor/nm-connection-editor.c    
> >> 2008-10-10 16:04:57.000000000 +0200
> >> @@ -405,7 +405,9 @@
> >>  nm_connection_editor_save_vpn_secrets (NMConnectionEditor *editor)
> >>  {
> >>      GSList *iter;
> >> +    GtkWidget *system;
> >>  
> >> +    system = glade_xml_get_widget (editor->xml, "connection_system");
> >>      g_return_if_fail (NM_IS_CONNECTION_EDITOR (editor));
> >>      g_return_if_fail (nm_connection_get_scope (editor->connection) == 
> >> NM_CONNECTION_SCOPE_USER);
> >>  
> >> @@ -417,5 +419,7 @@
> >>              break;
> >>          }
> >>      }
> >> +
> >> +    gtk_widget_set_sensitive (GTK_WIDGET (system), FALSE);
> >>  }
> >>
> >> _______________________________________________
> >> NetworkManager-list mailing list
> >> NetworkManager-list gnome org
> >> http://mail.gnome.org/mailman/listinfo/networkmanager-list
> >>     
> >
> >
> >   
>