Re: API changes

[Derek Atkins <warlord MIT EDU>]

Hey,

Dan Williams <dcbw redhat com> writes:

> On Thu, 2008-05-08 at 16:59 +0300, Tambet Ingo wrote:
>> Hey,
>> 
>> There's a small DBus API breakage in the SVN. Interface
>> "org.freedesktop.NetworkManager.IP4Config" does not have properties
>> "Address", "Gateway", "Netmask", and "Broadcast" anymore. Instread,
>> there's now an array of tuples 'Addresses' containing (uint address,
>> uint netmask, uint gateway). The change was to allow multiple IP
>> addresses per device. Here's the diff:
>
> As a side-note, this exactly matches the format for IP addresses that
> the NMSettingIP4Config setting uses.
>
> Dan
>
>> -    <property name="Address" type="u" access="read">
>> -      <tp:docstring>IPv4 address. FIXME: what about multiple
>> addresses?</tp:docstring>
>> -    </property>
>> -    <property name="Gateway" type="u" access="read">
>> -      <tp:docstring>Default gateway.</tp:docstring>
>> -    </property>
>> -    <property name="Netmask" type="u" access="read">
>> -      <tp:docstring>Network mask of this network.</tp:docstring>
>> -    </property>
>> -    <property name="Broadcast" type="u" access="read">
>> -      <tp:docstring>Broadcast address of this network.</tp:docstring>
>> +    <property name="Addresses" type="aau" access="read">
>> +      <tp:docstring>Tuples of IPv4 address/netmask/gateway.  The
>> gateway is optional, if not given should be 0.</tp:docstring>

Why not call it V4Addresses, to give space to add V6Addresses later?

>> Tambet

-derek
-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord MIT EDU                        PGP key available