Re: [PATCH] Fix manual IP config

On Mon, Mar 17, 2008 at 10:32 AM, Helmut Schaa <hschaa suse de> wrote:
>  nm_device_get_use_dhcp returns true when "priv->dhcp_manager != NULL".
>  1. Since priv->dhcp_manager does not get initialized anywhere it may be !=
>  NULL but not set to a correct value. Therefore nm_device_get_use_dhcp will
>  return true even when not using dhcp. Setting it explicitly with
>  nm_device_set_use_dhcp (self, FALSE) works around this issue.

GObject's initialization sets all the internal structure members to NULLs.

>  2. Assume a DHCP-connection on that device. When you switch to a manual
>  connection priv->dhcp_manager remains set and therefor the manual IP
>  configuration is ignored.

Ah, so that's the real bug. When a device gets deactivated, it should
call that function. I'll make that change today, thanks for figuring
it out.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]