Re: [PATCH] support for domain-search, request for comments/testing

[Dan Williams <dcbw redhat com>]

On Fri, 2008-03-07 at 08:42 +0100, Michael Biebl wrote:
> Dan Williams wrote:
> > On Thu, 2008-03-06 at 19:15 +0100, Michael Biebl wrote:
> >> Michael Biebl wrote:
> >>> Hi everyone,
> >>>
> >>> a few days ago I received a contribution in form of a patch [1], which
> >>> adds domain-search support to NetworkManager (0.6).
> >>> I'll be quoting the relevant part here:
> >>>
> >> [..]
> >>> one, which supports this domain-search option. I currently don't have
> >>> access to a dhcp3-server with support for domain-search, so I can't test
> >>> it myself. Thus this request for testing.
> >>> I'd also like to know, if this patch has a chance of making into 0.6.6,
> >>> and if not, if you plan to release a 0.6.6.1 or 0.6.7 and what you think
> >>> of the patch in general.
> >> Any comments or feedback?
> > 
> > I think in general it's the right thing to do, I have to go back and
> > look over the patch more closely (need to fix some of the coding style
> > too).
> 
> Ok, thanks. Will you also forward-port it to 0.7?

Yeah.

> > It's too late for 0.6.6 (going to cut that today and the change is too
> > high-risk) but we could do a 0.6.6.1 if you like.
> 
> Sounds good to me.
> I'll probably apply the patch to the upcoming Debian 0.6.6-1 packages in
> unstable, which should also give it some wider testing. In case
> something horribly breaks, I'd let you know then.

Great, sounds like a plan.

Dan