Re: [PATCH] Fixing NetworkManager-openvpn

[Dan Williams <dcbw redhat com>]

On Fri, 2008-07-18 at 12:13 -0400, Nathaniel McCallum wrote:
> Short story: stock plugin doesn't work for me and here's a patch that
> makes it work.
> 
> Long story: There are two issues.
> 1. When attempting to set the direction on the --tls-auth option, the
> direction should only be set if it is a non-empty string.  This is
> trivial and can be merged right away.

Thanks, committed to SVN.

> 2. Why does NM set --ns-cert-type?  Won't this just break half of the
> VPN's out there whose admins didn't set up a server cert.  Does it
> *really* matter?

Nope.  And they got removed a while back from upstream SVN.  I was just
rebuilding NM today for Fedora and was going to do the VPN plugins next,
which would bring in this change.

Dan