Re: [patch] fix openvpn's hashtable warning and crash when edit configuration

[Dan Williams <dcbw redhat com>]

On Tue, 2008-02-05 at 11:07 +0800, Charles Li wrote:
> Hi,

The properties applet should ensure that the NMSettingVPNProperties is
created and added to the connection, and that object initializes the
hash table in it's init() function, so I don't think this patch is
needed.  What versions (or SVN dates) of the applet and NM sources are
you using?

Dan

> Index: NetworkManager/vpn-daemons/openvpn/properties/nm-openvpn.c
> ===================================================================
> --- NetworkManager.orig/vpn-daemons/openvpn/properties/nm-openvpn.c
> +++ NetworkManager/vpn-daemons/openvpn/properties/nm-openvpn.c
> @@ -256,6 +256,12 @@ impl_fill_connection (NetworkManagerVpnU
> 
>         s_vpn_props = NM_SETTING_VPN_PROPERTIES
> (nm_connection_get_setting (connection,
> NM_TYPE_SETTING_VPN_PROPERTIES));
>         g_return_if_fail (s_vpn_props != NULL);
> +
> +       /* create new hash table for vpn's properties */
> +       s_vpn_props->data = g_hash_table_new(g_str_hash, g_str_equal);
> +
> +       g_return_if_fail (s_vpn_props->data != NULL);
> +
>         properties = s_vpn_props->data;
> 
>         /* Connection name */
> 
> 
> _______________________________________________
> NetworkManager-list mailing list
> NetworkManager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list