Re: [PATCH] Support for openvpn --fragment option

[Jochen Friedrich <jochen scram de>]

Hi Dan,

> The fragment option is only applicable with UDP, so if we could rework
> the UI a bit that would be great.  Instead of having a checkbox for "Use
> TCP", lets move that option to the bottom of the list and make it a
> popup menu, like so:
> 
>    [ ] Use LZO data compression
> 
>    [ ] Use a TAP device
> 
>                         .-----------------.
>    Connection protocol: | UDP (default)   |   (<---- menu has TCP too)
>                         `-----------------'
>                                               .--------.
>           [ ] Custom fragmentation threshold: | 1300 |X|
>                                               `--------'
> 
> Where, of course, the custom fragmentation threshold would be disabled
> (gtk_widget_set_sensitive (..., FALSE);) when TCP was selected.  The
> spinbox should also have sensible upper and lower bounds, like maybe >=
> 500 and <= 1492.
> 
> Sound OK?  Mind whipping up that patch?  The rest of it looks good.

Thanks for your comments. I'll look into this in two weeks after my holidays.

Thanks,
Jochen