Re: [PATCH] Add dhcp timeout and anycast config options

[Sjoerd Simons <sjoerd luon net>]

On Tue, Aug 05, 2008 at 02:05:51PM -0400, Dan Williams wrote:
> On Tue, 2008-08-05 at 18:10 +0100, Sjoerd Simons wrote: 
> > > I'd rather not have configurable DHCP timeouts in this manner because for
> > > non-mesh cases, the DHCP timeout never needs to change.  If we can set the
> > > DHCP timeout for mesh operations in the activation request like the old code
> > > did, that would be preferable.
> > 
> > I guess i could do that. But that would mean mixing device configuration
> > and ip configuration for mesh devices, which doesn't seem the right way to
> > me. I don't really see any harm in exposing this functionality for all
> > devices (although maybe we should clamp it to a certain min and max value)?
> 
> Well, the mesh code is specific for OLPC, and the DHCP timeouts there were
> tuned to the specific mesh cases and behavior that we had with
> OLPC.

Well hopefully the mesh code will become less OLPC specific soon. As
mesh-support is now in the mainline linux kernel and should work with all
mac80211s devices. But indeed this change is indeed a tad specific to the OLPC
usecase.

> Furthermore, DHCP timeouts shouldn't need to be changed in general
> anyway.  People always try to get the DHCP timeout raised for wireless
> stuff, but the fact is that if you're not connected in 45 seconds, the
> driver has a bug, your key is wrong, or you're waaay out of range.
> There is no good reason to allow user-configurable DHCP timeouts at this
> point.
> 
> Just because the option can be tweaked doesn't mean it should in 99% of
> cases.

Just because you can set the property in the D-Bus interface doesn't mean you
have to :) But yeah, i'll rewrite this to not expose the dhcp timeout setting
in the general ip4 config properties.

What are your feelings about the anycast property, as it's probably even more
specific to OLPC?

  Sjoerd
-- 
Science and religion are in full accord but science and faith are in complete
discord.