Re: [PATCH] [2/3] Use libnl instead of iproute/AF_PACKET (nm_system_device_replace_default_ipv4_route)

[Benoit Boissinot <bboissin+networkmanager gmail com>]

On Wed, Apr 23, 2008 at 01:55:00PM -0400, Dan Williams wrote:
> On Wed, 2008-04-23 at 19:26 +0200, Benoit Boissinot wrote:
> > On Wed, Apr 23, 2008 at 07:01:14PM +0200, Benoit Boissinot wrote:
> > > On Wed, Apr 23, 2008 at 12:23:45PM -0400, Dan Williams wrote:
> > > > probably need to poke Thomas about this one, before I start
> > > > instrumenting iproute2 to dump the netlink packets it sends, doing the
> > > > same for libnl, and see what's different.
> > > 
> > > I'm on it, I can reproduce it (and I've already dumped libnl vs iproute).
> > 
> > got it, we have to set the scope to RT_SCOPE_UNIVERSE, there's an XXX in
> > libnl:
> > /* XXX Change to UNIVERSE if gw || nexthops */
> > 
> > so I should add rtnl_route_set_scope(route, RT_SCOPE_UNIVERSE); to all
> > patches that add a route with a gateway.
> > 
> > Should I resend them ? (or preferably fix libnl first ?)
> 
> Lets not block on libnl though, just fix up and resend patch #2.  Both
> #1 and #3 work fine for me.  We can poke thomas to fix libnl in
> parallel, or we can come up with patches for it ourselves and push them
> to him.

#3 should need it too, I'll resend.
(I've tested nl-route-add dst 10.0.0.3 via 192.168.0.124 dev wlan0, and
it fails without the right scope)

regards,

Benoit
-- 
:wq