Re: patch for PPPoE problem

[Dan Williams <dcbw redhat com>]

On Wed, 2008-04-16 at 21:56 +0800, 陈鑫 wrote:
> Dear Dan,
> 
>          I used PPPoE function of NetworkManager with ppp-2.4.4，I
> found some problems and fixed it.

Thanks!  Committed to SVN.  Can you verify that the version I committed
works for you?  I added a pap_check_hook that returns 1, which from
reading pppd/auth.c and PLUGINS in pppd seem to be what we should be
doing there.

Dan

> ChangeLog
> 
>         * src/nm-device-802-3-ethernet.c
>           -(real_deactivate_quickly):  clear ip_iface of the device.
> nm_system_device_set_from_ip4_config() used  to use pppoe interface,
> when link changes from pppoe to dhcp,
>        * src/ppp-manager/nm-pppd-plugin.c
>           -(get_credentials): when checking pap authentication in
> pppd, parameter passwd is NULL, check it and return 1 to support pap.
>           -(plugin_init): define chap_check_hook() to support chap
> authentication.
>         * src/ppp-manager/nm-ppp-manager.c
>           -(create_pppd_cmd_line): fixed obvious error when creating
> pppd command line.
> 
> 
> Regards,
> znscn
> _______________________________________________
> NetworkManager-list mailing list
> NetworkManager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list