Re: NetworkManager static-routes support patch

[Dan Williams <dcbw redhat com>]

On Thu, 2007-06-07 at 15:12 +0200, Blonďák wrote:
> Hi, 
> i wrote patch for NetworkManager for support static-routes from DHCP
> (033).

Nice!  A few comments...

- instead of doing "(*temp_route).host", just use "temp_route->host".
That shows up in a few places.

- do static routes -always- have a netmask of 0xffffffff?

- I'd prefer to have the nm_ip4_config_add_static_route() function
_copy_ the NMIP4Route structure and append it to the list.  The
NMIP4Config should also free any NMIP4Route structures that it has
references to when it is destroyed.  Once you've done this don't forget
to free the malloc-ed NMIP4Route structure too.  Also please check for a
NULL return value after the malloc and print out a warning and break out
of the for() loop.  Should also check for NULL return from the g_malloc0
when you add that to nm_ip4_config_add_static_route and return.

- There are some spaces after the ( in nm_ip4_config_add_static_route():
+    g_return_if_fail ( config != NULL);

Thanks!
Dan

> With regards
> 
> Blondak
> 
> 
> _______________________________________________
> NetworkManager-list mailing list
> NetworkManager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list