Re: Proposed ad-hoc channel bug patch

[Dan Williams <dcbw redhat com>]

On Tue, 2007-12-25 at 18:22 +0200, Ohad Lutzky wrote:
> On Dec 25, 2007 4:03 PM, Dan Williams <dcbw redhat com> wrote:
> > On Tue, 2007-12-25 at 10:29 +0200, Ohad Lutzky wrote:
> > > Hi Dan,
> > >
> > > Thanks for the info. A few questions -
> > >
> > > * Is there any chance indeed that the feature will be backported into
> > > wpa_supplicant 0.5.x? Or is it a big restructuring of wpa_sup which
> > > will make this very difficult?
> >
> > No, it's pretty easy and fairly contained.  It's just the config option
> > and the driver hooks for setting the frequency.
> >
> > > * Which version of NM uses wpa_supplicant 0.6.x, with the new feature?
> > > Is a GUI for setting the channel present? Is any sort of channel set
> > > for ad-hoc mode?
> >
> > No version of NM requires 0.6.x.  All the D-Bus interface work has been
> > done on wpa_supplicant 0.5.7 and later but the changes also get applied
> > to the 0.6.x branch.
> >
> > NM does not yet honor the channel setting for either adhoc or
> > infrastructure mode because the backend wpa_supplicant support is not
> > yet there.
> 
> I'm not sure I understand... is the wpa_supplicant support for channel
> setting there in 0.6.x or not? When can we expect NM to use this
> support?

Channel support exists in wpa_supplicant 0.6.x for Ad-Hoc configs.  It
does not exist for locking to a specific channel for Infrastructure
configs.

> I'm trying to use NM from my application which uses ad-hoc networking
> heavily (a port of a Windows application, specifically), and current
> behavior is completely broken for all of the cards I have. Would it be
> acceptable to use this patch downstream (Debian, Ubuntu) for the time
> being?

No, not really.  Hacks have a habit of sticking around, and not all
drivers really need this either.  It ends up being a problem on ipw2x00
for example, but not libertas, airo, atmel, etc.  It's just another
example of drivers being inconsistent.

Dan

> >
> > Dan
> >
> >
> > > Much thanks,
> > > Ohad.
> > >
> > > On Dec 25, 2007 12:57 AM, Dan Williams <dcbw redhat com> wrote:
> > > > On Thu, 2007-12-20 at 10:55 +0200, Ohad Lutzky wrote:
> > > > > Hi all,
> > > > >
> > > > > Apparently it's not a WPA issue after all. Please check patch attached here:
> > > > >
> > > > > https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/112009/comments/12
> > > >
> > > > Contrary to the bug report, it's _totally_ a wpa_supplicant issue.
> > > > wpa_supplicant 0.6.x has the required config option, it needs to be
> > > > backported to wpa_supplicant 0.5.x.  NM should _not_ be setting any
> > > > wireless attributes like channel, BSSID, or SSID itself.
> > > >
> > > > So the patch is wrong.
> > > >
> > > > Dan
> > > >
> > > >
> > > >
> > >
> > >
> > >
> >
> >
> 
> 
>