Re: [PATCH] Add WPA2 to allowed protocols

[Helmut Schaa <hschaa suse de>]

Am Mittwoch, 8. August 2007 13:37:07 schrieb Dan Williams:
> On Wed, 2007-08-08 at 10:45 +0200, Helmut Schaa wrote:
> > attached is a patch against trunk which adds WPA2 to the allowed
> > protocols for wpa_supplicant. Is there any reason why it was not in the
> > list yet? If not please commit to trunk.
>
> Because RSN == WPA2 for wpa_supplicant.  We only need one.  The user
> agent/applet is free to show what it likes in the UI, but it should pass
> only RSN to NetworkManager for the configuration.

Thanks for the explanation ;-)

Therefore a more appropriate patch would be to replace WPA2 options in NM 
itself by RSN. Right? Here you are.

Regards,
Helmut

Index: nm-ap-security-wpa-eap.c
===================================================================
--- src/nm-ap-security-wpa-eap.c	(Revision 2656)
+++ src/nm-ap-security-wpa-eap.c	(Arbeitskopie)
@@ -199,7 +199,7 @@
 		if (!nm_supplicant_config_add_option (config, "proto", "WPA", -1))
 			goto out;
 	} else {
-		if (!nm_supplicant_config_add_option (config, "proto", "WPA2", -1))
+		if (!nm_supplicant_config_add_option (config, "proto", "RSN", -1))
 			goto out;
 	}
 
Index: nm-ap-security-wpa-psk.c
===================================================================
--- src/nm-ap-security-wpa-psk.c	(Revision 2656)
+++ src/nm-ap-security-wpa-psk.c	(Arbeitskopie)
@@ -148,7 +148,7 @@
 		if (!nm_supplicant_config_add_option (config, "proto", "WPA", -1))
 			goto out;
 	} else if (self->priv->wpa_version == IW_AUTH_WPA_VERSION_WPA2) {
-		if (!nm_supplicant_config_add_option (config, "proto", "WPA2", -1))
+		if (!nm_supplicant_config_add_option (config, "proto", "RSN", -1))
 			goto out;
 	}