Re: [Patch] openvpn with TCP

[Dan Williams <dcbw redhat com>]

On Mon, 2006-10-02 at 17:26 +0300, Tambet Ingo wrote:
> On Mon, 2006-10-02 at 10:06 -0400, Dan Williams wrote:
> > Patch looks fine; but did OpenVPN previously use 'tcp'?  Or has it
> > always used 'tcp-client'?  It seems odd that there is a 'udp' option,
> > but the TCP option is called 'tcp-client'.  I'd expect it to be either
> > 'tcp' & 'udp', or 'tcp-client' & 'udp-client'.  I don't want to break
> > stuff on an upgrade unless we know exactly what we're breaking.
> 
> >From the information I could gather (mostly from openvpn ChangeLog), it
> looks like 'tcp' is provided as a shortcut, but only works if the
> '-server' or '-client' part can be guessed (from --mode I think). The
> first time '--proto tcp-client' is mentioned in the ChangeLog is from
> 2004.01.14 -- Version 1.6-beta1.

Ok, patch looks good then.  Feel free to commit if you've got all that
set up.  Thanks!

Dan

> Tambet
>