Re: [PATCH] NetworkManager dies if PPTP activation fails due to timeout

[Dan Williams <dcbw redhat com>]

On Thu, 2006-11-23 at 10:02 +0100, Helmut Schaa wrote:
> Hi,
> 
> When trying to establish a VPN connection using PPTP which times out,
> NetworkManager gets killed. 
> 
> The reason is that pppd runs with the same process group ID as NetworkManager 
> and the PPTP service. On timeouts, pppd gets the signal SIGTERM which is also 
> sent to all other processes of this group.  Thus, both NetworkManager and the 
> PPTP services get killed, too.
> 
> The following patch resolves this issue by setting the process group ID of the 
> pppd process to its own process ID. I have attached two patches (one against 
> HEAD and one against STABLE).

Which makes me think; we could probably solve this issue for all VPN
helpers if we did this in nm-vpn-service.c,
nm_vpn_service_stage1_daemon_exec(), right?  I can't think of any reason
why the vpn helpers _need_ to run in the same pgid as NM, it was likely
an oversight that they got this way in the first place.

Any objections to applying that patch to nm-vpn-service.c instead?

Thanks,
Dan

> Perhaps this is interesting for other services like dialup too.
> 
> Regards
> Helmut
> _______________________________________________
> NetworkManager-list mailing list
> NetworkManager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list