Re: [patch 0/3] Multiple domains and OpenVPN

[Dan Williams <dcbw redhat com>]

On Mon, 2006-08-28 at 15:41 +0200, groug free fr wrote:
> Hi,
> 
> I just re-send a serie of patches I had sent a few monthes ago, just in case it
> makes it to the CVS repository this time. ;)

Hi,

I haven't forgotten that set!

But back then I didn't really like the incompatible way we were
extending the D-Bus API bits of NM, so I wrote the dbus-dict-helper code
that's in libnm-utils.  I'd prefer to have all this stuff put into a
dict rather than the fragile argument ordering stuff we do now.  This
change won't make it into the stable 0.6.x branch, since we can't break
D-Bus compat there (again).  But it can certainly go into HEAD if it
gets converted to the new system of dicts.  I was going to do that
personally, but I'm a bit busy with the wpa_supplicant D-Bus
integration, so if you get to it first I'll be happy to review and apply
a patch.

Dan

> The goal of this serie of patches is to bring support for multiple domains
> pushed by an OpenVPN server. For this, some work had to be done:
> 
> - named manager: propagate on DBUS all the domains stored in the IP4
> structure. Only the first one was handled, don't know why... design constraint
> I missed ?
> 
> - vpn manager: the message between the vpn daemons and the vpn manager was only
> dealing with a single domain. It was extended to be an array of domains. The
> affected field of the message still can be a bare string to preserve
> compatibility.
> 
> - openvpn helper: domain wasn't parsed at all. Now, pushed domains are parsed
> and put in the message to the vpn manager.
> 
> --
> -gr0n6-
> 
> "Anarchy is about taking complete responsibility for yourself."
>         Alan Moore.
> 
> _______________________________________________
> NetworkManager-list mailing list
> NetworkManager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list