Re: Copyright symbol patch broken

[Christopher Aillon <caillon redhat com>]

On 10/27/2005 10:13 PM, Matthew Saltzman wrote:
> On Thu, 27 Oct 2005, Christopher Aillon wrote:
>
> > On 10/27/2005 04:24 PM, Matthew Saltzman wrote:
> > > Attempt to make the latest CVS (1.593) fails with:
> > >
> > > make[1]: Entering directory `/home/mjs/fedora/NetworkManager/po'
> > > INTLTOOL_EXTRACT=../intltool-extract srcdir=. ../intltool-update 
> > > --gettext-package NetworkManager --pot
> > > ERROR: xgettext failed to generate PO template file because there is 
> > > non-ASCII
> > >        string marked for translation. Please make sure that all 
> > > strings marked
> > >        for translation are in uniform encoding (say UTF-8), then 
> > > *prepend* the
> > >        following line to POTFILES.in and rerun intltool-update:
> > >
> > >            [encoding: UTF-8]
> > >
> > > Backing out the last patch (update copyright symbol in 
> > > gnome/applet/applet.c fixes the issue.
> > ... Does prepending the line to POTFILES.in not fix the issue for you?
>
> To be honest, I didn't try.  It asks to verify that all strings are 
> UTF-8, and I didn't have time to do so.  I just looked at the 
> changelog and the last annotation said something relevant to character 
> sets, so I backed it out.
>
> I just did try it now, and adding the prefix seems to work, but I did 
> not verify the encoding of all messages beyond that.
The other strings were ASCII (since backing out the copyright thing 
fixed it for you) and UTF-8 subsumes ASCII.  So, I just committed the 
encoding fix.

Thanks!