Re: [patch] more stetic, broken up, 2/2

[Bryan Clark <bclark redhat com>]

Hi ~

On Thu, 2005-06-16 at 21:32 -0400, Robert Love wrote:
> Meanwhile, this patch includes the following changes:
> 
>         - Don't center the "Wireless Networks" menu item.
>         - Actually make the "Wireless Networks" menu item inactive.
>           I realize this was done deliberately (with the nasty signal
>           hack), but the thing /is/ insensitive, unselectable, and a
>           label, not a menu item.  The greyed-out look is in.
>         - Use gtk_menu_new_with_label(), not the previous complications.

So that was definitely done purposefully, here's why. :-)  We didn't use
a disabled menu item because those are reserved for items that will
_eventually_ become enabled.  In your menus the items are either
enabled, disabled with a possibility of becoming enabled, or not there
at all.  Since the 'Wireless Networks' item never actually becomes
enabled we opted to leave it normal.  Opposite is the 'Wired Network'
menu which does become enabled when you have a wired connection, and
thus we felt a disabled item was perfect for that.  To make the Wireless
Network item stand out as "something you won't be clicking on", we
centered it. The centering also gives a header style look to it that I
think works.

I didn't pay attention to what was done to make that magic happen in the
code, but I definitely think it's better to not make it a disabled menu
item.  The non-greyed-out look is retro these days and soon will be
mainstream, at which point we'll be too cool for it and leave it.

>         - Consolidate a few seemingly related functions, all called from
>           the same place once, into one.

That sounds cool to me...

> 	- Draw a horizontal separator above the "Wireless Networks"
> 	  label.

The line I think is a little excessive to add it.  It makes the whole
menu look very boxy, especially without the other label change.

Cheers,
~ Bryan