Re: [patch] don't display very-low-strength APs.

[Peter Jones <pjones redhat com>]

On Mon, 2005-07-11 at 16:10 -0400, Dan Williams wrote:
> On Mon, 2005-07-11 at 15:47 -0400, Robert Love wrote:
> > As featured in several award-winning news reports[1], Cambridge has a
> > lot of wireless networks.  I finally got strength working on the Cisco
> > AiroNet card, and I see that many of those networks have no strength
> > whatsoever.
> > 
> > My Mac only shows a few access points, effectively filtering the crappy
> > access points out.
> > 
> > Attached patch filters out access points at or below 1% strength.  In
> > addition to not displaying worthless AP's, this keeps the number of
> > transient networks down--less falling in and out of display.
> > 
> > The one concern is if any wireless cards with broken strength detection
> > return zero for all strength.  I've only seen 100% returned, so I think
> > this is okay.
> 
> Hmm, my concern with this is that not all cards do support this yet, and
> not all cards conform to the WEXT spec.  For instance, ipw2100 cards
> don't seem to work with the latest stable ipw2100 driver.  The all show
> 0 strength.

What do the other values show?  That is, are _all_ the quality values 0?
Also what do the updated flags say?

We could make nm_wireless_qual_to_percent() actually return -1 (which it
arguably should anyway in some of the cases where it's clamped), and
then make this test for != -1 .

That is, if we have _real_ quality info, don't show anything that's
absurdly low, but if we don't, then show everything.
-- 
        Peter